Improve how filenames are parsed to generate file id #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a new implementation of the approach for getting file ids from filenames. Explicit regex patterns corresponding to known ACCESS output filenames are now matched to generate a file id (by redacting time stamps and replacing non-python characters) and extract any time information contained in the filename. This approach to generating the file id is probably more robust than the old approach (see #67). Additionally, the time information extracted is used in conjunction with the output of
get_timeinfo
to make it more robust (see #20) and could also be useful elsewhere (e.g. see #62)